From 8b4595d6713ddcea9109474b3d2877441c905671 Mon Sep 17 00:00:00 2001 From: Sven Hoexter Date: Wed, 19 Aug 2026 14:44:25 +0200 Subject: [PATCH] Drop d/patches/do-not-phone-home.patch * Drop d/patches/do-not-phone-home.patch: It disabled all sort of connections to the developers website. It's still open to the user to disable all downloads in the UI. Upstream kindly asked me to make that change. * Add d/patches/disable-version-update.patch: It's not helpful to propose version update for distribution packaged software which might end up in a stable release for some years. --- debian/changelog | 6 +++ debian/patches/cmake-installs.patch | 2 +- debian/patches/disable-version-update.patch | 41 +++++++++++++++++++++ debian/patches/do-not-phone-home.patch | 16 -------- debian/patches/series | 2 +- 5 files changed, 49 insertions(+), 18 deletions(-) create mode 100644 debian/patches/disable-version-update.patch delete mode 100644 debian/patches/do-not-phone-home.patch diff --git a/debian/changelog b/debian/changelog index 917c91d..010f0f2 100644 --- a/debian/changelog +++ b/debian/changelog @@ -3,6 +3,12 @@ vym (3.0.0+git20260819-1) UNRELEASED; urgency=medium * New upstream snapshot of vym 3. Upstream commit 931dba5263992b85cd04591fdf798ff5cd4a65a5, branch develop. * d/copyright: Update to 2026. + * Drop d/patches/do-not-phone-home.patch: It disabled all sort of + connections to the developers website. It's still open to the user to + disable all downloads in the UI. Upstream kindly asked me to make that change. + * Add d/patches/disable-version-update.patch: It's not helpful to propose + version update for distribution packaged software which might end up in + a stable release for some years. -- Sven Hoexter Wed, 19 Aug 2026 14:38:57 +0200 diff --git a/debian/patches/cmake-installs.patch b/debian/patches/cmake-installs.patch index 54a6100..a656b69 100644 --- a/debian/patches/cmake-installs.patch +++ b/debian/patches/cmake-installs.patch @@ -7,7 +7,7 @@ Index: vym/CMakeLists.txt =================================================================== --- vym.orig/CMakeLists.txt +++ vym/CMakeLists.txt -@@ -238,16 +238,18 @@ message(STATUS "vym: CMAKE_INSTALL_DATAR +@@ -288,16 +288,18 @@ message(STATUS "vym: CMAKE_INSTALL_DATAR install(DIRECTORY demos DESTINATION ${CMAKE_INSTALL_DATAROOTDIR}/${VYM_SHARE_SUBDIR}) diff --git a/debian/patches/disable-version-update.patch b/debian/patches/disable-version-update.patch new file mode 100644 index 0000000..838db18 --- /dev/null +++ b/debian/patches/disable-version-update.patch @@ -0,0 +1,41 @@ +Description: Disable Version Update Check +Author: Sven Hoexter +Last-Update: 2026-08-19 +Forwarded: not-needed +Index: vym/src/mainwindow.cpp +=================================================================== +--- vym.orig/src/mainwindow.cpp ++++ vym/src/mainwindow.cpp +@@ -3707,10 +3707,12 @@ void Main::setupHelpActions() + helpMenu->addAction(a); + connect(a, SIGNAL(triggered()), this, SLOT(checkReleaseNotes())); + ++ /* Removed, checking versions for a distribution package is not helpful + a = new QAction(tr("Check, if updates are available", "Help action"), this); + helpMenu->addAction(a); + connect(a, SIGNAL(triggered()), this, SLOT(checkUpdates())); + helpMenu->addSeparator(); ++ */ + + a = new QAction(tr("Show keyboard shortcuts", "Help action"), this); + helpMenu->addAction(a); +@@ -8140,9 +8142,6 @@ bool Main::vymDownloadsEnabled(bool user + "If you allow, vym will " + "
    " + "
  • check once for release notes
  • " +- "
  • check regulary for updates and notify you in case you " +- "should update, e.g. if there are " +- "important bug fixes available
  • " + "
  • receive a cookie with a random ID and send some anonymous data, like:" + "
      " + "
    • vym version
    • " +@@ -8263,6 +8262,9 @@ void Main::downloadUpdates(bool userTrig + + void Main::checkUpdates() + { ++ // Return early, checking versions for a distribution package is not helpful ++ return; ++ + bool userTriggered; + if (qobject_cast(sender())) + userTriggered = true; diff --git a/debian/patches/do-not-phone-home.patch b/debian/patches/do-not-phone-home.patch deleted file mode 100644 index 39c27bb..0000000 --- a/debian/patches/do-not-phone-home.patch +++ /dev/null @@ -1,16 +0,0 @@ -Description: Disable build-in auto-updater. -Author: Sven Hoexter -Last-Update: 2024-05-03 -Forwarded: not-needed -Index: vym/src/mainwindow.cpp -=================================================================== ---- vym.orig/src/mainwindow.cpp -+++ vym/src/mainwindow.cpp -@@ -8096,6 +8096,7 @@ void Main::checkReleaseNotes () - - bool Main::downloadsEnabled(bool userTriggered) - { -+ return false; - bool result; - if (!userTriggered && - settings.value("/downloads/enabled", false).toBool()) { diff --git a/debian/patches/series b/debian/patches/series index 4707ce1..6585fe6 100644 --- a/debian/patches/series +++ b/debian/patches/series @@ -1,2 +1,2 @@ cmake-installs.patch -do-not-phone-home.patch +disable-version-update.patch -- 2.47.3