X-Git-Url: https://git.sven.stormbind.net/?p=sven%2Fscripts.git;a=blobdiff_plain;f=home%2Fpvmon2opsgenie.sh;fp=home%2Fpvmon2opsgenie.sh;h=c5b970e78f8597d8653d18c798e2ff4d1cb1ba46;hp=34a5c5af86cf68749286487894727e28c4ed0978;hb=8d0198c269d90ea3c1a7f60225aabb7577b7b194;hpb=795e2766cb2798789364c5933153274ad1b27818

diff --git a/home/pvmon2opsgenie.sh b/home/pvmon2opsgenie.sh
index 34a5c5a..c5b970e 100755
--- a/home/pvmon2opsgenie.sh
+++ b/home/pvmon2opsgenie.sh
@@ -1,10 +1,9 @@
 #!/bin/sh
-# Checks inverter state as repoted by a metecontrol weblog
+# Checks inverter state as repoted by a meteocontrol weblog
 # device HTML interface, reports issues via Atlassian
 # Opsgenie. Written with the intention to run via cron on
 # a LTE Router with either OpenWRT or Teltonika RutOS.
-# Requires curl for the Opsgenie part, otherwise
-# sh/cut/cat/wget/test are enough.
+# Requires curl other stock sh/cut/cat/test are enough.
 
 # createAlert <alias> <message> <description>
 createAlert() {
@@ -84,7 +83,7 @@ parseMcOutput() {
         return
     fi
 
-    grep "cLink" "${file}" | while read line; do 
+    grep "cLink" "${file}" | while read line; do
         result="$(parseMcLine \"${line}\")"
         # good case
         if [ "${result}" = "OK" ]; then
@@ -114,7 +113,7 @@ getMCstates() {
     rm -f "${outfile}"
 
     # ready to try to download the data from meteocontrol
-    if ! wget -q -O "${outfile}" "${url}"; then
+    if ! curl -s -o "${outfile}" "${url}"; then
         echo "ERROR: could not download ${url} into ${outfile}"
         exit 1
     fi
@@ -149,8 +148,8 @@ API_HOST="api.eu.opsgenie.com"
 API_KEY=""
 
 # adjust meteocontrol default password and IPs
-mc1="http://admin:ist02@192.168.1.2:80/html/de/onlineOverWr.html"
-mc2="http://admin:ist02@192.168.1.3:80/html/de/onlineOverWr.html"
+mc1="http://admin:ist02@192.168.1.2/html/de/onlineOverWr.html"
+mc2="http://admin:ist02@192.168.1.3/html/de/onlineOverWr.html"
 
 ### main loop
 for dev in mc1 mc2; do
@@ -170,7 +169,7 @@ for dev in mc1 mc2; do
         createAlert "${dev}" "PV ${dev}" "${failures}"
         continue
     fi
-    
+
     # update alert state close alert on state change
     checkAlertState "${statefile}" "OK" && \
     closeAlert "${dev}"